Upcoming Patrick releases: test cases have invalid strings for glue interpolation

[michaelquinn32]

The next version of patrick (the parameterized testing package) will use glue interpolation for test cases. There are test case names in lintr that contain code in curly braces, which throw errors when glue_data is called on them.

Here are some examples:

• lintr/tests/testthat/test-fixed_regex_linter.R

  Line 61 in 06f2b9c

  "^", "$", "{", "}", "(", ")", ".", "*", "+", "?",

• lintr/tests/testthat/test-pipe_continuation_linter.R

  Line 139 in 06f2b9c

  local({

My choice would be to add literal names to these test cases. While this is a little less informative than showing the data, it still seems to get the point across.

    char <- c(
      caret = "^",
      dollar = "$",
      curly_brace_open = "{",
      curly_brace_close = "}",
      parenthesis_open = "(",
      parenthesis_close = ")",
      period = ".",
      asterisk = "*",
      plus = "+",
      question_mark = "?",
      pipe = "|",
      square_bracket_open = "[",
      square_bracket_close = "]",
      backslashes = "\\\\",
      angle_bracket_open = "<",
      angle_bracket_close = ">",
      equals = "=",
      colon = ":",
      semicolon = ";",
      forward_slash = "/",
      underscore = "_",
      dash = "-",
      exclamation_mark = "!",
      at = "@",
      hash = "#",
      percent = "%",
      ampersand = "&",
      tilde = "~"
    )