You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running github issue_update_alpha_pending for sirepo shows no message, but it failed to update the pending alpha issue with an approved PR from the prior day. I manually updated the pending alpha issue for now. For the next sirepo PR approval, we should check if the alpha issue gets updated. It could have been an end-of-year issue and will fix itself for now.
The text was updated successfully, but these errors were encountered:
robnagler
changed the title
github issue_update_alpha_pending fails silently
github issue_update_alpha_pending should check back further
Jan 7, 2025
I changed the title. issue_update_alpha_pending doesn't fail when it doesn't find issues, because there's no guarantee that there is an issue to add. (It has nothing to do with years.) The code checks back 24 hours. When you created this issue, it was 1/7 21:49 UTC. The PR was committed 1/6 22:06 which is under 24 hours ago. It could be that github decided not to return that commit due to the date. It's a bit hard to say. However, it should go back more than 24 hours. It will print "ignoring" if the commit is already included, which is obviously less of a problem. We run a command every 24 hours to make sure we catch all commits periodically so normally this isn't a problem.
Running github issue_update_alpha_pending for sirepo shows no message, but it failed to update the pending alpha issue with an approved PR from the prior day. I manually updated the pending alpha issue for now. For the next sirepo PR approval, we should check if the alpha issue gets updated. It could have been an end-of-year issue and will fix itself for now.
The text was updated successfully, but these errors were encountered: