From bf3b40107072678cfa59808395261ddeaa372596 Mon Sep 17 00:00:00 2001 From: Oscar Bernardini Date: Tue, 19 Mar 2024 14:51:49 +0100 Subject: [PATCH 1/2] fix: leftover idp issuer for name qualifier check --- src/response.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/response.ts b/src/response.ts index 516fbd1..835efc4 100644 --- a/src/response.ts +++ b/src/response.ts @@ -153,7 +153,7 @@ export class SpidResponse extends XML.XML { ); assert.strictEqual( data.subject.nameIdQualifier, - saml.idpIssuer, + idpIssuer, `Invalid NameQualifier "${data.subject.nameIdQualifier}"`, ); // SubjectConfirmation From 85be700d6aaebf59f894f0c2630932e4e71bec41 Mon Sep 17 00:00:00 2001 From: Oscar Bernardini Date: Tue, 19 Mar 2024 15:06:54 +0100 Subject: [PATCH 2/2] chore: add missing test script to package.json --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 9869bb3..3ff350a 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,8 @@ "build": "tsc", "prepare": "run-s build", "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"", - "lint": "eslint \"{src,test}/**/*.ts\" --fix" + "lint": "eslint \"{src,test}/**/*.ts\" --fix", + "test": "bash ./test.sh" }, "dependencies": { "@node-saml/node-saml": "^4.0.0",