Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching from tower_lsp to something else #39

Open
ratmice opened this issue May 11, 2024 · 0 comments
Open

Consider switching from tower_lsp to something else #39

ratmice opened this issue May 11, 2024 · 0 comments

Comments

@ratmice
Copy link
Owner

ratmice commented May 11, 2024

While tower_lsp has been great, because of the lifetime bounds on the traits we end up spinning up threads for the parsers and communicating between the lsp thread and the parse threads via channels, because the parsers cannot be held across await points, and there isn't a means to instantiate the server in a local set afaict.

This use of multiple threads then has an impact on porting to wasm and also means we're split between async and sync parts of the codebase. So it would probably be worthwhile to cut our losses and migrate to the lsp-server crate or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant