Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set popup window height #103

Open
cd-a opened this issue Feb 18, 2022 · 5 comments
Open

Set popup window height #103

cd-a opened this issue Feb 18, 2022 · 5 comments

Comments

@cd-a
Copy link

cd-a commented Feb 18, 2022

I can't find a way to adjust the height of the popup window.

For example when I do either of those 2:

<Plug>(ultest-output-show)
<Plug>(ultest-attach)

The popup is just 20 lines high, which isn't really enough.

Is there a config option for that which I have overlooked?

@wookayin
Copy link

Relevant lines: autoload/ultest/output.vim, function s:NvimOpenFloat. There is no such options yet and it is simply set to the content height. Some options like max_height should be added.

rcarriga added a commit that referenced this issue Feb 19, 2022
BREAKING CHANGE: Drop 0.4.4 support

See #103
@rcarriga
Copy link
Owner

I've added in config variables to control the window size. Please try the latest commit

                                                   *g:ultest_output_max_width*
Max width of the output window (default: 0)

                                                  *g:ultest_output_max_height*
Max height of the output window (default: 0)

                                                   *g:ultest_output_min_width*
Min width of the output window (default: 0)

                                                  *g:ultest_output_min_height*
Min height of the output window (default: 0)

@cd-a
Copy link
Author

cd-a commented Feb 19, 2022

@rcarriga Thanks for taking this on, appreciate it.

A few things I noticed:

  1. The default width/height should probably be changed, without any settings it's just 20 wide. But that might also be because of the second point below

Screenshot 2022-02-19 at 10 50 23

  1. The width can not be higher than the height for some reason.
let g:ultest_output_min_width = 70
let g:ultest_output_max_width = 70 
let g:ultest_output_min_height = 10

This results in a 10:10 window
Screenshot 2022-02-19 at 10 59 13

Using the max here for the width has no effect. So the width seems to have the height as the upper boundary

When I set the height to 20 and keep width at 70, it is now 20:20

rcarriga added a commit that referenced this issue Feb 19, 2022
@rcarriga
Copy link
Owner

That's what happens when dealing with long and similar variable names 😅 Please try latest, should be working now

@cd-a
Copy link
Author

cd-a commented Feb 19, 2022

Thank you so much, it works now, very cool!

One last thing: Is it possible to adjust the window distance at the bottom?
Screenshot 2022-02-19 at 12 53 09

My commandline is 2 lines high, and above that there is the status line. If I could add 2 extra lines distance then it would not clip. Is that possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants