Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quaternion slerp parameters order? #95

Open
Benualdo opened this issue Jan 8, 2025 · 1 comment
Open

Quaternion slerp parameters order? #95

Benualdo opened this issue Jan 8, 2025 · 1 comment
Assignees
Labels

Comments

@Benualdo
Copy link
Contributor

Benualdo commented Jan 8, 2025

Hi, I'm confused about the parameters of quaternion slerp function

Interpolating between two quaternions, it looks like a value of 1 for blend factor will return the 1st parameter and a value of 0 will return the 2nd value.

image

but the comments in code says the opposite:

image

For other types such as float4, the parameters are in the correct order.
image

Thanks.

@Benualdo Benualdo changed the title Quaternion slerp parameters order? (x64) Quaternion slerp parameters order? Jan 8, 2025
@redorav
Copy link
Owner

redorav commented Jan 8, 2025

Hmmm that sounds a bit odd but I think I don't use slerp in my codebase so it looks like it slipped my radar. I'll fix and add to the unit tests when I get a chance. Thanks for reporting!

@redorav redorav self-assigned this Jan 8, 2025
@redorav redorav added the bug label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants