Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Laravel 9 support #64

Closed
Pilskalns opened this issue Feb 11, 2022 · 9 comments
Closed

Laravel 9 support #64

Pilskalns opened this issue Feb 11, 2022 · 9 comments

Comments

@Pilskalns
Copy link

Hi,

This package is dependent on rinvex/tmp-watson-validating ^6.0.0 which in turn depends on illuminate/validation ^8.0 thus breaking the dependency chain. To my understanding, the dependencies on validating package should be updated.

The full dependency chain:
L9 > rinvex/laravel-addresses ^6.0 > rinvex/laravel-support ^6.0.0 > rinvex/tmp-watson-validating ^6.0.0 > illuminate/validation ^8.0.0

P.S. creating issue here since the tmp-watson-validating package does not have Issue Tracker enabled.

@robbielove
Copy link

We don't even need the tmp-watson-validating anymore - this fork was originally used because https://github.com/dwightwatson/validating didn't have L8 support.

It now has L9 support so it could just be switched to use that and problem solved? 🤷‍♂️

@stephenjude
Copy link

Yeah was trying to add L9 support because of the same issue. What's do you suggest @robbielove

@Omranic
Copy link
Member

Omranic commented Feb 12, 2022

@Pilskalns @stephenjude thanks, L9 support coming this week 👍

@robbielove awesome, that's good news, will check that and switch it back then 🙌

@stephenjude
Copy link

Thanks @Omranic

@Omranic
Copy link
Member

Omranic commented Feb 14, 2022

Laravel v9 is now supported in latest release v6.1.0, also all of our packages now supports Laravel v9.

Note when using this package with Laravel v9

This package requires felixkiss/uniquewith-validator dependency, which is not yet compatible with Laravel v9! However as a temporary workaround, add Laravel Shift's fork to the repositories property of your project root composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/uniquewith-validator.git"
        }
    ]
}

@azenot-dev
Copy link

Laravel v9 is now supported in latest release v6.1.0, also all of our packages now supports Laravel v9.

Note when using this package with Laravel v9

This package requires felixkiss/uniquewith-validator dependency, which is not yet compatible with Laravel v9! However as a temporary workaround, add Laravel Shift's fork to the repositories property of your project root composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/uniquewith-validator.git"
        }
    ]
}

I get this error
GitHub API limit (0 calls/hr) is exhausted, could not fetch https://api.github.com/repos/laravel-shift/uniquewith-validator/commits/ad94e9b14bca5e7afd9a578c023fe3937d6bcdaa. Create a GitHub OAuth token to go over the API rate limit. You can also wait until ? for the rate limit to reset.

@Omranic
Copy link
Member

Omranic commented Jan 3, 2023

Update: we dropped the felixkiss/uniquewith-validator dependency from this package 🙂 2bf69b8

@robbielove
Copy link

Thanks for that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants