From 881bc24fce490b7ba077f04a68d1916e56448f59 Mon Sep 17 00:00:00 2001 From: Chenna Keshava B S Date: Tue, 17 Sep 2024 21:28:23 -0700 Subject: [PATCH 1/2] Add validation checks for Payment transaction --- shared/base.yaml | 1 + shared/transactions/payment.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/shared/base.yaml b/shared/base.yaml index 8a5b55d..cc36747 100644 --- a/shared/base.yaml +++ b/shared/base.yaml @@ -206,6 +206,7 @@ components: currency: type: string description: 'Arbitrary currency code for the token. Cannot be XRP.' + pattern: '^[a-z]{3}$' value: type: string pattern: '^[-+]?[0-9]*\.?[0-9]+([eE][-+]?[0-9]+)?$' diff --git a/shared/transactions/payment.yaml b/shared/transactions/payment.yaml index b21ef5a..3aa958f 100644 --- a/shared/transactions/payment.yaml +++ b/shared/transactions/payment.yaml @@ -24,6 +24,7 @@ components: InvoiceID: type: string description: '(Optional) Arbitrary 256-bit hash representing a specific reason or identifier for this payment.' + maxLength: 256 Paths: type: array items: From 617a1a0094daf349c3e4c18698c603f321c39376 Mon Sep 17 00:00:00 2001 From: Chenna Keshava B S Date: Wed, 18 Sep 2024 15:27:20 -0700 Subject: [PATCH 2/2] RPC validation checks, default values --- shared/requests/account_lines.yaml | 3 +++ shared/requests/ledger_entry.yaml | 1 + shared/requests/submit.yaml | 2 ++ 3 files changed, 6 insertions(+) diff --git a/shared/requests/account_lines.yaml b/shared/requests/account_lines.yaml index 57c27b4..698e436 100644 --- a/shared/requests/account_lines.yaml +++ b/shared/requests/account_lines.yaml @@ -19,6 +19,9 @@ components: limit: type: integer description: (Optional) Limit the number of trust lines to retrieve. Must be within the inclusive range 10 to 400. Default is 200. + minimum: 10 + maximum: 400 + default: 200 marker: type: object description: (Optional) Value from a previous paginated response. Resume retrieving data where that response left off. diff --git a/shared/requests/ledger_entry.yaml b/shared/requests/ledger_entry.yaml index 254f440..f1d0ba4 100644 --- a/shared/requests/ledger_entry.yaml +++ b/shared/requests/ledger_entry.yaml @@ -6,6 +6,7 @@ components: binary: type: boolean description: (Optional) If true, return the requested ledger entry's contents as a hex string in the XRP Ledger's binary format. Otherwise, return data in JSON format. The default is false. + default: false include_deleted: type: boolean description: (Optional, Clio servers only) If set to true and the queried object has been deleted, return its complete data as it was prior to its deletion. If set to false or not provided, and the queried object has been deleted, return objectNotFound (current behavior). diff --git a/shared/requests/submit.yaml b/shared/requests/submit.yaml index ecf4800..fb16d86 100644 --- a/shared/requests/submit.yaml +++ b/shared/requests/submit.yaml @@ -20,6 +20,7 @@ components: fail_hard: type: boolean description: 'If true, and the transaction fails locally, do not retry or relay the transaction to other servers. Default is false.' + default: false required: - tx_blob @@ -45,6 +46,7 @@ components: fail_hard: type: boolean description: '(Optional) If true, and the transaction fails locally, do not retry or relay the transaction to other servers. Default is false. Updated in: rippled 1.5.0' + default: false offline: type: boolean description: '(Optional) If true, when constructing the transaction, do not try to automatically fill in or validate values. Default is false.'