unpin_misskey checks for wrong error code when note not found

[ssmucny]

At

pleroma-bot/pleroma_bot/_pin.py

Line 71 in 9a64891

if response.status_code == 404: # pragma

the response code is checked against 404 to see if the note cannot be found, but Misskey returns a 400 when no note is found. See https://misskey.io/api-doc#operation/i/unpin for API reference.

[robertoszek]

Hi!
You're absolutely right!
I completely missed this on my own testing as the end result was the same on my end due to another bug 😅 (so the bot gave up unpinning it and the post to unpin was already deleted, so no harm no foul there).

Thanks for bringing it to my attention!
I have committed the change (and the fix for the another bug) to the develop branch:
85cfbed

And I also have published it as a release candidate v1.2.1rc2, which anyone interested or who needs it right now can install like so:

pip install -i https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple pleroma-bot==1.2.1rc2

Nevertheless, this change will be included on the next stable release, thanks once again for your contribution!