Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move berdy into hde library #250

Closed
lrapetti opened this issue May 25, 2021 · 6 comments
Closed

Move berdy into hde library #250

lrapetti opened this issue May 25, 2021 · 6 comments
Assignees

Comments

@lrapetti
Copy link
Member

As discussed in #243, we should proceed to move the berdy algorithm implementation out of iDynTree into hde library.

From iDynTree side, I think it was discussed with @traversaro and there should be no problem.

We can proceed by moving berdy, as it is, into the library changing all the related namespaces. Once that is done, and the hde master works fine, we can update berdy with the sot implementation (from robotology/idyntree#783)

@traversaro
Copy link
Member

From iDynTree side, I think it was discussed with @traversaro and there should be no problem.

Sure, the only problem is if you want to have matlab bindings in HDE (that is doable, but not trivial).

@lrapetti
Copy link
Member Author

From iDynTree side, I think it was discussed with @traversaro and there should be no problem.

Sure, the only problem is if you want to have matlab bindings in HDE (that is doable, but not trivial).

Sorry, I forgot this point. Anyway, probably sooner o later we should address it.

Anyway, this is relevant for @claudia-lat.

cc @DanielePucci

@traversaro
Copy link
Member

A possible way forward inline with recent devs in the lab is to wrap the code in Python with pybind11 or SWIG, and then call the resulting Python from MATLAB (see ami-iit/bipedal-locomotion-framework#53 (comment)).

@lrapetti
Copy link
Member Author

lrapetti commented Jun 7, 2021

I did an initial test trying to port the current berdy implementation (from iDynTree master) in the branch human-dynamics-estimation/tree/add-berdy. Everything seems to be compiling fine in Ubuntu, but I am getting some compilation error in MacOS and Windows CI.

I will try to investigate further.

If those errors are fixed, I think the porting would be done. However, I think before moving definitely to hde-berdy, we should take care of the problem of the bindings.

A possible way forward inline with recent devs in the lab is to wrap the code in Python with pybind11 or SWIG, and then call the resulting Python from MATLAB (see dic-iit/bipedal-locomotion-framework#53 (comment)).

I have opened a specific issue for this #255.

@lrapetti
Copy link
Member Author

lrapetti commented Jun 7, 2021

Everything seems to be compiling fine in Ubuntu, but I am getting some compilation error in MacOS and Windows CI.

in particular the problem is due to the lines that are uncommented in 46951de. Without those lines, I was able to compile and run everything on MacOS, and all the CI tests were passed.

@lrapetti
Copy link
Member Author

This is no longer planned, Berdy for the time-being will remain in iDynTree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants