-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quaternion/Position order is not coherent between logger and thrift #413
Comments
If we want to change for harmonization, I would stick to linear/angular serialization as much as possible. Recently I also investigated integrating iDynTree and pinocchio in https://github.com/ami-iit/idynfor, and also in pinocchio the serialization used is linear/angular, see https://github.com/ami-iit/idynfor/blob/97ff77e6f148cabe7d95f51ee1c67958e9c9f918/doc/theory_background.md#rigid-body-velocity . |
Yess, in general I agree with this. It would actually be a very quick change in the code. The main issue, however, is that it would break all the datasets that we logged in the past using the |
If we have them saved all somewhere, we could write a simple tool to convert the datasets between the old and the new version. But I do not know if doing that is worth the time/effort necessary to do that. |
This solution is certainly feasible, but we have multiple datasets around so it might be difficult to track all the dataset changes |
Describe the bug
With @Zweisteine96 we noticed difference in the linear/angular serialization used used for iFeel data:
The difference between logger and thrift has created some confusion.
This opens ups to some solutions:
Any suggestion/opinion @RiccardoGrieco @traversaro @diegoferigo ?
The text was updated successfully, but these errors were encountered: