Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_view] is color correction still required? #810

Closed
MyronRodrigues-StreetDrone opened this issue Apr 26, 2023 · 1 comment
Closed
Assignees

Comments

@MyronRodrigues-StreetDrone

I'm using ros humble and have the R and B colors flipped even though my image has correct encoding rgb8. The colors look right when seen from cv::imshow()

Color conversion on line 190 from branch humble in image_pipeline/image_view/src/image_view_node.cpp, is still required?

queued_image_.set(
  cv_bridge::cvtColorForDisplay(
    cv_bridge::toCvShare(msg), "bgr8", options));
@mikeferguson
Copy link
Member

The real fix here is that we should be reading the encoding from the image message - and defaulting to bgr8 (the preferred) if no encoding is found - #850 fixes that

@mikeferguson mikeferguson self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants