Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model pose should not be a critical error #37

Open
asherikov opened this issue Jan 10, 2025 · 1 comment
Open

model pose should not be a critical error #37

asherikov opened this issue Jan 10, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@asherikov
Copy link

Currently model conversion fails if a pose tag is found in model -> https://github.com/ros/sdformat_urdf/blob/rolling/sdformat_urdf/src/sdformat_urdf.cpp#L99. I believe in this context this is not really an error and conversion should proceed with a warning or completely ignore these tags.

@sloretz sloretz added the enhancement New feature or request label Jan 10, 2025
@sloretz
Copy link
Contributor

sloretz commented Jan 10, 2025

I could see how a warning would be ok in this case.

I'd recommend against silently ignoring <pose> tags in a <model>. If someone does know that pose is relative to a larger context, they might wonder why it's not included in transforms between frames like map or odom and frames in their model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants