Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system-upgrade: Add offline-distrosync, offline-upgrade subcommand aliases #1343

Closed
evan-goode opened this issue Mar 25, 2024 · 0 comments · Fixed by #1344
Closed

system-upgrade: Add offline-distrosync, offline-upgrade subcommand aliases #1343

evan-goode opened this issue Mar 25, 2024 · 0 comments · Fixed by #1344
Assignees

Comments

@evan-goode
Copy link
Member

@kontura wrote #1280 (comment):

I see these aliases don't match the dnf4 commands.
It basically changes dnf offline-distrosync download -> dnf5 offline-distrosync and discards the rest.

We do have all the functionality so I think we could build the aliases to (more or less) fit.

Something like:

['offline-distrosync']
type = 'command'
attached_command = 'distro-sync'
group_id = 'commands-compatibility-aliases'
complete = true

['offline-distrosync.download']
type = 'command'
attached_command = 'distro-sync'
complete = true
attached_named_args = [
{ id_path = 'distro-sync.offline' }
]

['offline-distrosync.log']
type = 'command'
attached_command = 'offline.log'
complete = true
...

(If we do decide to do that I would rather do it in a separate PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant