Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize build process - Do not create object files archive library libdnf5_static.a #2003

Open
jrohel opened this issue Jan 13, 2025 · 0 comments · May be fixed by #2004
Open

Optimize build process - Do not create object files archive library libdnf5_static.a #2003

jrohel opened this issue Jan 13, 2025 · 0 comments · May be fixed by #2004
Assignees
@jrohel
Labels
Priority: LOW RFE Request For Enhancement (as opposed to a bug) Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@jrohel
Copy link
Contributor

jrohel commented Jan 13, 2025 •
edited
Loading

The libdnf5_static.a object files archive is not packaged. It is only used in unit tests of the libdnf5 library. The use of the archive in libdnf5 unit tests is intentional. The tests call private methods that have hidden symbols not exported by the shared library.

Currently in my development build libdnf5_static.a takes about 75MiB. In the case of compiling with disabled optimizations and with WITH_SANITIZERS it takes about 250MiB.

Try to optimize the build process so that the libdnf5 unit tests still link statically, but do not need the intermediate step of creating a object files archive library libdnf5_static.a.
@jrohel jrohel self-assigned this Jan 13, 2025
@jrohel jrohel changed the title Optimize build process - Do not create static library libdnf5_static.a Optimize build process - Do not create object files archive library libdnf5_static.a Jan 13, 2025
@jrohel jrohel linked a pull request Jan 13, 2025 that will close this issue
Open
@ppisar ppisar added RFE Request For Enhancement (as opposed to a bug) Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrohel jrohel

Labels
Priority: LOW RFE Request For Enhancement (as opposed to a bug) Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize build process: Do not create object files archive library libdnf5_static.a jrohel/dnf5
2 participants
@ppisar @jrohel