Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve versioning scheme of RXNO & MOP #37

Open
StroemPhi opened this issue Mar 30, 2022 · 5 comments
Open

improve versioning scheme of RXNO & MOP #37

StroemPhi opened this issue Mar 30, 2022 · 5 comments

Comments

@StroemPhi
Copy link
Contributor

StroemPhi commented Mar 30, 2022

At the moment the versions of RXNO and MOP are declared in the ontology metadata using:
<owl:versionIRI rdf:resource="http://purl.obolibrary.org/obo/mop/releases/2022-02-01/mop.owl"/> &
<owl:versionIRI rdf:resource="http://purl.obolibrary.org/obo/rxno/releases/2021-12-16/rxno.owl"/>
Unfortunately these IRIs are not resolvable as there are no releases other than the files in the root dir.

TODOs:

  • switch to ODK setup with proper release artefacts in the long run
  • think about manually making GitHub releases to resolve to or a release folder in the root dir
  • add owl:versioninfo and maybe a comment/documentation to the recent release process
@StroemPhi
Copy link
Contributor Author

StroemPhi commented Mar 31, 2022

@colinbatchelor if you were to make a release using the date for the release tag, I could make a PR updating the metadata YAML so that the verionIRI will resolve to this and future releases. Using the BSPO.yaml as blueprint.
@matentzn would this be an ok interim solution until we find the time to switch to ODK?

@StroemPhi
Copy link
Contributor Author

And @matentzn do I understand it correctly that since there is no rxno-edit.owl for edits (improvements) between releases, a new release woul dhave to be made whenever changes are merged into main?

@StroemPhi
Copy link
Contributor Author

If my above assumtion is true, wrt to a proper transparent release process, it might be better to have another branch upstream (e.g. dev or testing) to which I could push contributions from our NFDI4Chem fork and thus bundle smaller issue based edits. This way @colinbatchelor could wait until a certain number of contributions have been made before merging the dev branch into main and then making a release. All edits made on the dev branch would then be the changes one could list in the release info, right? Or would it be better to have this "dev" be the main one in our fork, @matentzn? Sorry for such GH noob questons.

@matentzn
Copy link

I think at the very minimum there should be a

  • rxno-edit.owl (file you do the day to day editing, no version iri)
  • rxno.owl (released version with merged imports, associated with tags and containing a version iri)
  • rxno-base.owl (rxno without imported terms)
  • rxno.obo

You only run release as you see fit - merging to master does not mean you have to run a release. We usually run monthly or quarterly releases, and whenever we need to on demand..

@StroemPhi
Copy link
Contributor Author

Thanks a lot @matentzn! There is no ODK workflow yet, so "run release" will mean doing this all manually atm. But this already helps me to propose this minimum in PRs to @colinbatchelor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants