Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin update and Compatibility check #18

Open
4 of 5 tasks
dhawalepranav opened this issue Dec 11, 2023 · 9 comments
Open
4 of 5 tasks

Plugin update and Compatibility check #18

dhawalepranav opened this issue Dec 11, 2023 · 9 comments
Assignees

Comments

@dhawalepranav
Copy link

dhawalepranav commented Dec 11, 2023

We need to complete the following set of tasks for Embed Google Drive plugin.

  • Make sure it's compatible with latest WordPress version. (e.g 6.6.X )
  • Make sure it's PHP 8.2 compatible.
  • Make sure it's VIP compatible
  • Run the PHPCS scan
  • Document the user manual with screenshots that will include things like "How to install plugin", "Plugin Pre-requisites" "How to setup plugin for first time", "Plugin Settings with their use case" etc

Before starting the work please add your time estimations for every mentioned task and get it approved by your Project Co-ordinator or Project Manager

@SH4LIN
Copy link
Contributor

SH4LIN commented Dec 14, 2023

Task estimation: 7-9hrs

Tasks breakdown

  • Check the compatibility with the latest WordPress version 1-2hr
  • Check the code is compatible with the PHP 8.2 1-2hr
  • Make sure it's VIP compatible 45mins
  • Fix the PHPCS issues 15mins
  • Generated the documentation with the screenshots and user manual 2-3hr
  • QA of the plugin 1hr

CC: @dhawalepranav @joelabreo227

@SH4LIN
Copy link
Contributor

SH4LIN commented Dec 14, 2023

The plugin also needs its text domain to be updated as mentioned in here

If your plugin is hosted on wordpress.org it must be the slug portion of your plugin URL (wordpress.org/plugins/<slug>)

Plugin's WordPress org slug is this https://wordpress.org/plugins/embed-google-drive -> (embed-google-drive) and current text domain is rt-google-embeds it needs to be refactored from rt-google-embeds to embed-google-drive.

This change will have a time estimation of 1hr

  • Need to change the file names, and text domain, Generate POT file with new text domain.

@dhawalepranav

@SH4LIN
Copy link
Contributor

SH4LIN commented Dec 15, 2023

Installation

  1. Download the plugin from here
  2. Add the plugin from the WordPress admin panel.


  3. Activate the plugin through the 'Plugins' menu in WordPress
  4. Paste a shared Google Drive document link into the WordPress editor.

@dhawalepranav I am documenting these steps for the Installation of the plugin and how to use it.

@SH4LIN
Copy link
Contributor

SH4LIN commented Dec 15, 2023

Task update: PHP 8.2 compatibility sweep completed. No issues were found

WordPress 6.4.2 compatibility sweep completed. No issues were found.

PHPCS with WordPress and WordPress-VIP-Go standard fixed.

Documented how to install and use the plugin.

@dhawalepranav

@SH4LIN
Copy link
Contributor

SH4LIN commented Dec 15, 2023

@dhawalepranav Updated README.md

Installation

  1. Download the plugin from here
  2. Add the plugin from the WordPress admin panel.


  3. Activate the plugin through the 'Plugins' menu in WordPress

How to use

  1. Copy the URL of drive document which you want to embed. Note: The document must be shared with anyone with the link.
  2. Create new post/page or edit existing one.
  3. Paste the URL in the editor. It will automatically embed the document.
    image
    image
    image

Video Guide

Screen.Recording.2023-12-15.at.1.15.39.PM.mov

SH4LIN added a commit that referenced this issue Dec 18, 2023
@SH4LIN
Copy link
Contributor

SH4LIN commented Dec 21, 2023

Update

The plugin update required some additional tasks other than those mentioned before.

  • Go through the WordPress plugin release documentation and verify every step mentioned there. ~2hr
  • Perform manual testing after every minor update. Plugin release ~1hr

CC: @dhawalepranav

@nirajgiriXD
Copy link

Tasks

Since the plugin has already been tested up to PHP 8.2 by @SH4LIN, I will proceed with testing it for WordPress 6.6. ~2hr

cc: @vishal4669

@SH4LIN
Copy link
Contributor

SH4LIN commented Jul 19, 2024

@nirajgiriXD Also, test the plugin upto PHP 8.3

@nirajgiriXD
Copy link

Updates

  • PHP 8.3 compatibility sweep completed. No issues were found
  • WordPress 6.6 compatibility sweep completed. No issues were found

cc: @vishal4669, @SH4LIN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants