Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warnings With Python 3.12 #1032

Closed
kitterma opened this issue Jan 7, 2024 · 5 comments
Closed

Deprecation Warnings With Python 3.12 #1032

kitterma opened this issue Jan 7, 2024 · 5 comments

Comments

@kitterma
Copy link
Contributor

kitterma commented Jan 7, 2024

Describe the bug
When the 2.5.0~rc1 test suite is run with python3.12, there are deprecation warnings:

tests/test_resolver.py::PollResolverTestCase::testQuicNameserver
  /usr/lib/python3/dist-packages/aioquic/tls.py:218: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    now = utcnow()
tests/test_resolver.py::PollResolverTestCase::testQuicNameserver
  /usr/lib/python3/dist-packages/aioquic/tls.py:1390: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    timestamp = utcnow()

To Reproduce
Run the test suite with Python 3.12

Context (please complete the following information):

  • dnspython version [e.g. 2.2.1] 2.5.0~rc1
  • Python version [e.g. 3.10.0] 3.12.1
  • OS: [e.g. macOS Monterey] Debian Unstable
@rthalley
Copy link
Owner

rthalley commented Jan 7, 2024

This is an aioquic issue which will be fixed in a future release of aioquic, probably shortly after cryptography 42.0.0 ships.

@rthalley
Copy link
Owner

rthalley commented Jan 7, 2024

See this aioquic PR for the latest info.

@kitterma
Copy link
Contributor Author

kitterma commented Jan 7, 2024 via email

@rthalley
Copy link
Owner

rthalley commented Jan 8, 2024

I'll keep this ticket open so we remember to increment the aioquic version requirement when there is a fix.

rthalley added a commit that referenced this issue Mar 12, 2024
@rthalley
Copy link
Owner

Fixed with aioquic 1.0.0 requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants