Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Date Filter performance #26

Open
rubberduck203 opened this issue Nov 15, 2020 · 0 comments
Open

Improve Date Filter performance #26

rubberduck203 opened this issue Nov 15, 2020 · 0 comments

Comments

@rubberduck203
Copy link
Owner

Currently, we perform filtering by walking every commit in history, then filtering the commits after the fact.

var diffs = await AsyncVisitorFactory(repo).Walk(branch.Tip);
var filteredDiffs = diffs.Where(diffFilter.Invoke);

It would be far more efficient, particularly when analyzing repos with long histories, if we had a different visitor that stopped walking the history once it hit the date we're looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant