Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a remove duplicates functionality #267

Open
shaydonb opened this issue Jan 10, 2025 · 1 comment · May be fixed by #268
Open

Create a remove duplicates functionality #267

shaydonb opened this issue Jan 10, 2025 · 1 comment · May be fixed by #268

Comments

@shaydonb
Copy link

Problem: Sometimes register names contain duplicate strings that
unnecessarily lengthen them.

Solution: Remove the largest duplicated substring, with a specified
delimiter to avoid removing mere duplicated characters.
shaydonb pushed a commit to shaydonb/svdtools that referenced this issue Jan 10, 2025
@shaydon-eero
feat: Remove largest duplicate substr of reg name
1f9bdf8 
Problem: Sometimes register names contain duplicate strings that
unnecessarily lengthen them.

Solution: Remove the largest duplicated substring, with a specified
delimiter to avoid removing mere duplicated characters.

Testing: Unit-level test of helper function, integration level test with
SVD file in and expected out.

Issues: Closes rust-embedded#267.
@shaydonb shaydonb linked a pull request Jan 10, 2025 that will close this issue
Draft
@shaydonb
Copy link
Author

Hi folks, fumbling around with this new-to-me code base because I am working with some registers that have a lot of duplicated naming within. My unit-level test is passing, but the example patch.yaml doesn't yield the output I would hope to see, which is all duplicate names separated by the same delimiter removed.

Some basic printf debugging indicates that some matches are occurring but the structure of these data structures are a little hard to follow and I'm wondering if anyone might have any suggestions? Thanks in advance for taking a look at the draft PR.

shaydonb pushed a commit to shaydonb/svdtools that referenced this issue Jan 10, 2025
@shaydon-eero
feat: Remove largest duplicate substr of reg name
0e3ac47 
Problem: Sometimes register names contain duplicate strings that
unnecessarily lengthen them.

Solution: Remove the largest duplicated substring, with a specified
delimiter to avoid removing mere duplicated characters.

Testing: Unit-level test of helper function, integration level test with
SVD file in and expected out.

Issues: Closes rust-embedded#267.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Remove largest duplicate substr of reg name shaydonb/svdtools
1 participant
@shaydonb