Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50 Mb limit fix suggestion. #88

Open
JalmarazMartn opened this issue Jun 10, 2021 · 4 comments
Open

50 Mb limit fix suggestion. #88

JalmarazMartn opened this issue Jun 10, 2021 · 4 comments
Labels
effort: high Initial effort estimate: High enhancement New feature or request priority: medium Priority estimate: Medium

Comments

@JalmarazMartn
Copy link

About 50 mb file limit, I can tell you that I developed too a xliff help extension(I won´t put here the link because I don´t want to be a spammer) , and I had the same issue. I think the problem is using in xlf-document.ts class, function loadFromURI the sentence workspace.openTextDocument(sourceUri)).getText();
Instead using openTextDocument you can use:

   var fs = require('fs');
    const content = fs.readFileSync(FilePath,{encoding:'utf8', flag:'r'});

If you need a further split this content into lines you can do this:
const Lines = content.split('\r\n');

I am not sure 100 % you can fix the issue this way, but I remember this issue.

I hope this can help. Thank you for your extension.

@rvanbekkum
Copy link
Owner

Dear @JalmarazMartn,

Yes, that's an option to address this. I've had this on my internal backlog (in my head 🙃), but it is something that I have to put some time in to carefully adjust. I will most likely change this in a future update. Thanks for filing the issue. 😊

@rvanbekkum rvanbekkum added the enhancement New feature or request label Jun 11, 2021
@JalmarazMartn
Copy link
Author

Thank you for your extension @rvanbekkum . Have a nice day!!

@rvanbekkum
Copy link
Owner

We can leave it open. After I've implemented this I will close the issue accordingly. 🙂

@rvanbekkum rvanbekkum reopened this Jun 11, 2021
@rvanbekkum rvanbekkum added the effort: high Initial effort estimate: High label Dec 10, 2021
@rvanbekkum rvanbekkum added the priority: medium Priority estimate: Medium label Feb 17, 2022
@pri-kise
Copy link

Today I stumbled again about this error. Maybe you can at least add a try catch block with a warning that large files aren't supported right now.
At the moment nothing happens and the user don't know what happened.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: high Initial effort estimate: High enhancement New feature or request priority: medium Priority estimate: Medium
Projects
None yet
Development

No branches or pull requests

3 participants