-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to send user specific attachments #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you talk a bit about your use case for user-specific attachments, rather than campaign-wide ones?
for i, v := range att { | ||
attName, ok := v.(string) | ||
if !ok { | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a failed cast here shout at least emit a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return error here?
@rykov I ve accidentally pushed other commits to this PR too. They are |
@joeirimpan I haven't had a chance to think about how attachments will work, but I liked your idea of allowing custom subjects. So I've just pushed support for subject templating. Now you can do something like:
or in your case, you customize the whole subject:
Thank you for the idea, and I'll follow up on the other changes soon. |
Thanks for looking into this. But we created our own fully-fledged mailing list manager. Please do take a look :) |
@joeirimpan Nice! That's impressive. Happy to have more self-hosted alternatives to all the paid services. Maybe there's a possibility for compatibility/collaboration in the future. |
Fixes #13