Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test benchmark by changing feature extraction segment erasing with 0 values pixels outside of superpixel #40

Open
ryukinix opened this issue Nov 27, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ryukinix
Copy link
Owner

At first, change default value of erase_color parameter to 0.

egsis/egsis/features.py

Lines 163 to 171 in cc477cf

def feature_extraction_segment(
img: np.ndarray,
segments: np.ndarray,
label: int,
max_radius: Optional[int] = None,
centroid: Optional[List[int]] = None,
erase_color: Optional[int] = None,
feature_method: FeaturesMethods = "comatrix"
):

After running the benchmark, if metrics was improved by this change, consider erase_color being some kind of hyperparameter for EGSIS.

@ryukinix ryukinix added enhancement New feature or request good first issue Good for newcomers labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant