-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interact implementation doesn't seem to have nrows for buttons #534
Comments
The code insists on nrows dividing the number of entries, with 1..99 it works. So the question is whether this behaviour should be changed. |
Well, that is not in any of the several sources for documentation I found, so it presumably is a change (the examples on the Sage wiki even have screen shots?)
or
|
Sometime next week I hope to have a more stable document available, by the way - but the documentation that exists in various places is all pretty similar, it's just a matter of actually implementing that API in a few ways that changed because of Python or other changes. |
There are explicit checks for clean divisibility: https://github.com/sagemath/sagecell/blob/master/interact_sagecell.py#L768 |
There are explicit checks for clean divisibility:
https://github.com/sagemath/sagecell/blob/master/interact_sagecell.py#L768
This is not written by me, so they have been in place for at least 6
years. Dropping them off leads to errors in JavaScript as apparently those
controls can't handle such cases.
That's unfortunate. I would say to leave this issue open, then, but
obviously it's not worth trying to dig deeper this instant.
Trying your example in CoCalc - it works well, while Jupyter seems to
completely ignore nrows no matter if division is clean or not.
That's not surprising, but definitely useful info.
|
nrows
doesn't seem to do anything here:The text was updated successfully, but these errors were encountered: