Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GH replacements for various common ticket searches #130

Open
kcrisman opened this issue Jan 14, 2023 · 8 comments
Open

Document GH replacements for various common ticket searches #130

kcrisman opened this issue Jan 14, 2023 · 8 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@kcrisman
Copy link
Member

Searching is a bit wonky. This might be just a Github issue, in which case I guess you should close this. Details:

Just to test things out, I performed a search in issues for my handle kcrisman (and crisman). I got this while I was searching: https://34.105.185.241/sagemath/sage-all-2023-01-12-003/issues?page=40&q=is%3Aissue+kcrisman+is%3Aclosed

But clicking "Next" yields nothing. Or clicking on page 53 is the same thing. There are definitely earlier issues that should show up, and some of them do when I search for crisman instead. But not all! (For instance, https://34.105.185.241/sagemath/sage-all-2023-01-12-003/issues/2212 doesn't show up on either list, as far as I can tell.)

Anyway, my guess is that there are users with significantly more participation for whom this is also true, and certainly various keywords (graph, algebra, number field) would have many more, and having the search through issues not be complete is worrying (I never assume GH search through code is complete, I've been burned too many times by that). So it could be worth looking into, not just for historical reasons. Or if not, close 😄

@mkoeppe
Copy link

mkoeppe commented Jan 14, 2023

But clicking "Next" yields nothing. Or clicking on page 53 is the same thing.

The link that you provided is page 40, and clicking "Next" takes me to page 41, as expected. Page 53 is the last page, and Next is grayed out

For instance, https://34.105.185.241/sagemath/sage-all-2023-01-12-003/issues/2212 doesn't show up on either list, as far as I can tell.

Searching for "author:kcrisman" finds that issue:
https://34.105.185.241/sagemath/sage-all-2023-01-12-003/issues?q=is%3Aissue+is%3Aclosed+author%3Akcrisman+sort%3Acreated-asc

@kcrisman
Copy link
Member Author

The link that you provided is page 40, and clicking "Next" takes me to page 41, as expected. Page 53 is the last page, and Next is grayed out

That is weird. In neither Safari nor Firefox did this work for me; instead, I got a page saying "0 results" or something like that. Also for 53 (not the next page, I didn't mean to imply that). Finally, clicking on "41" yields the same result. And now I just tried yet again in Chrome, and got the same result, so it can't be a cache thing, one would think.

Searching for "author:kcrisman" finds that issue:

Sure, I'm not worried about it per se, but the easiest way to search GH is just typing a string in the issues box, and if it's not finding all instances of (say) cohomology that would be unfortunate. For testing it was easiest to pick something I knew a bit more about 😄

However, if nobody else can verify this, then I guess it must be a phantom. Thanks for checking, anyway.

@mkoeppe mkoeppe added the documentation Improvements or additions to documentation label Jan 15, 2023
@mkoeppe mkoeppe added this to the Switchover to GitHub milestone Jan 15, 2023
@mkoeppe mkoeppe added the help wanted Extra attention is needed label Jan 15, 2023
@mkoeppe mkoeppe changed the title search in issues doesn't return everything Document GH replacements for various common ticket searches Jan 15, 2023
@mkoeppe
Copy link

mkoeppe commented Jan 16, 2023

Basically we want a version of "Following the pulse of development" that uses GitHub searches instead of Trac reports/searches

@kwankyu
Copy link

kwankyu commented Jan 18, 2023

But clicking "Next" yields nothing. Or clicking on page 53 is the same thing.

The link that you provided is page 40, and clicking "Next" takes me to page 41, as expected. Page 53 is the last page, and Next is grayed out

For me, page 40 is the last page. It seems that pages 41 to 53 are just placeholders (for empty pages...)

@kwankyu
Copy link

kwankyu commented Jan 18, 2023

Basically we want a version of "Following the pulse of development" that uses GitHub searches instead of Trac reports/searches

This is a good topic for the new "Home" page of github wiki.

@kcrisman
Copy link
Member Author

kcrisman commented Jan 18, 2023 via email

@kwankyu
Copy link

kwankyu commented Feb 16, 2023

This is a good topic for the new "Home" page of github wiki.

I added some hints to the wiki https://github.com/sagemath/sage/wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants