Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use private hash implementation instead of hacked Abseil hash #10

Open
iamohcy opened this issue Nov 3, 2022 · 0 comments
Open

Use private hash implementation instead of hacked Abseil hash #10

iamohcy opened this issue Nov 3, 2022 · 0 comments
Assignees
@iamohcy
Labels
enhancement New feature or request

Comments

@iamohcy
Copy link
Collaborator

iamohcy commented Nov 3, 2022

Current HloDagHash utilizes the abseil cpp hash function, with a (rather hacky) patch to make the hash deterministic across runs. Ideally we'd want to utilize a deterministic hash algorithm, or if deterministic hashes across runs is not required we should remove this patch.
@iamohcy iamohcy added the enhancement New feature or request label Nov 3, 2022
@iamohcy iamohcy self-assigned this Nov 3, 2022
@mavenlin mavenlin changed the title Use private hash implementation instead of dependency on Abseil hash Use private hash implementation instead of hacked Abseil hash Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamohcy iamohcy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamohcy