Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap HloPass in Pass automatically #12

Open
iamohcy opened this issue Nov 3, 2022 · 0 comments
Open

Wrap HloPass in Pass automatically #12

iamohcy opened this issue Nov 3, 2022 · 0 comments

Comments

@iamohcy
Copy link
Collaborator

iamohcy commented Nov 3, 2022

As the Pass interface we use for our Pipeline differs from Xla's Pass Interface, we defined both our own Pass class which wraps XLA's HloPass class via pybind11. However this leads to confusing code where we have to wrap each HloPass in a Pass, e.g.:

fusion_pass = Pass(hloenv.HloPass.GeneralFusionPass())

It would be preferable to wrap it dynamically so we can just call

fusion_pass = hloenv.HloPass.GeneralFusionPass()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant