Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value metrics will broken when suffix is used #56

Open
imnpc opened this issue Oct 16, 2023 · 0 comments
Open

Value metrics will broken when suffix is used #56

imnpc opened this issue Oct 16, 2023 · 0 comments

Comments

@imnpc
Copy link

imnpc commented Oct 16, 2023

  • Laravel Version: 10.28.0
  • Nova Version: 4.27.14
  • PHP Version: 8.1.22
  • Database Driver & Version: mysql 8.0.34
  • Operating System and Version: Ubuntu 20.04.6 LTS(base on macOS 14 and homestead)
  • Browser type and version: Firefox 118.0.2

Description:

Nova-doc:https://nova.laravel.com/docs/metrics/defining-metrics.html#formatting-the-value

Detailed steps to reproduce the issue on a fresh Nova installation:

work ok

public function calculate(NovaRequest $request)
{
    return $this->max($request, Order::class, 'total')
                ->prefix('$');
}

work wrong

public function calculate(NovaRequest $request)
{
    return $this->max($request, Order::class, 'total')
                ->prefix('$')
                ->suffix('per unit');
}

error

TypeError: _util__WEBPACK_IMPORTED_MODULE_0__.singularOrPlural is not a function
    formattedSuffix linkable-metric:485
    run reactivity.esm-bundler.js:178
    get value reactivity.esm-bundler.js:1147
    get runtime-core.esm-bundler.js:3407
    default linkable-metric:1179
    r runtime-core.esm-bundler.js:766
    na runtime-core.esm-bundler.js:6995
    Vo runtime-core.esm-bundler.js:6806
    Go runtime-core.esm-bundler.js:6883
    Io runtime-core.esm-bundler.js:6733
    default linkable-metric:1164
    r runtime-core.esm-bundler.js:766
    oi runtime-core.esm-bundler.js:2824
    default LoadingCard.vue:11
    r runtime-core.esm-bundler.js:766
    oi runtime-core.esm-bundler.js:2824
    i Card.vue:3
    Wn runtime-core.esm-bundler.js:816
    effect runtime-core.esm-bundler.js:5764
    run reactivity.esm-bundler.js:178
    update runtime-core.esm-bundler.js:5814
    j runtime-core.esm-bundler.js:5641
    B runtime-core.esm-bundler.js:5576
    y runtime-core.esm-bundler.js:5040
    effect runtime-core.esm-bundler.js:5773
    run reactivity.esm-bundler.js:178
    update runtime-core.esm-bundler.js:5814
    j runtime-core.esm-bundler.js:5641
    B runtime-core.esm-bundler.js:5576
    y runtime-core.esm-bundler.js:5040
    effect runtime-core.esm-bundler.js:5773
    run reactivity.esm-bundler.js:178
    update runtime-core.esm-bundler.js:5814
    j runtime-core.esm-bundler.js:5641
    B runtime-core.esm-bundler.js:5576
    y runtime-core.esm-bundler.js:5040
    effect runtime-core.esm-bundler.js:5773
    run reactivity.esm-bundler.js:178
    update runtime-core.esm-bundler.js:5814
    cn runtime-core.esm-bundler.js:158
    On runtime-core.esm-bundler.js:357
    promise callback*_n runtime-core.esm-bundler.js:270
    An runtime-core.esm-bundler.js:264
    effect runtime-core.esm-bundler.js:5810
    Ie reactivity.esm-bundler.js:373
    Fe reactivity.esm-bundler.js:363
    Re reactivity.esm-bundler.js:337
    Xe reactivity.esm-bundler.js:487
    set runtime-core.esm-bundler.js:2986
    fetch linkable-metric:836
    promise callback*fetch linkable-metric:822
    created linkable-metric:799
    cn runtime-core.esm-bundler.js:158
    un runtime-core.esm-bundler.js:166
    un runtime-core.esm-bundler.js:176
    Li runtime-core.esm-bundler.js:3510
    Mi runtime-core.esm-bundler.js:3427
    _a runtime-core.esm-bundler.js:7341
    o runtime-core.esm-bundler.js:7265
    ba runtime-core.esm-bundler.js:7197
    D runtime-core.esm-bundler.js:5599
    B runtime-core.esm-bundler.js:5565
    y runtime-core.esm-bundler.js:5040
    effect runtime-core.esm-bundler.js:5708
    run reactivity.esm-bundler.js:178
    update runtime-core.esm-bundler.js:5814
    R runtime-core.esm-bundler.js:5822
    D runtime-core.esm-bundler.js:5613
    B runtime-core.esm-bundler.js:5565
    y runtime-core.esm-bundler.js:5040
    S runtime-core.esm-bundler.js:5285
    L runtime-core.esm-bundler.js:5499
    y runtime-core.esm-bundler.js:5015
    S runtime-core.esm-bundler.js:5285
    C runtime-core.esm-bundler.js:5191
    _ runtime-core.esm-bundler.js:5156
    y runtime-core.esm-bundler.js:5028
    S runtime-core.esm-bundler.js:5285
    C runtime-core.esm-bundler.js:5191
    _ runtime-core.esm-bundler.js:5156
runtime-core.esm-bundler.js:226:12

`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant