Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatArchive.fork error handling #17

Open
sammacbeth opened this issue May 17, 2018 · 0 comments
Open

DatArchive.fork error handling #17

sammacbeth opened this issue May 17, 2018 · 0 comments

Comments

@sammacbeth
Copy link
Owner

sammacbeth commented May 17, 2018

When DatArchive.fork is called with incorrect arguments the dialog still appears, but in a broken state. We should just reject immediately.

Reproduction:
The self-mutating site example calls DatArchive.fork with a DatArchive as the first argument (this is perhaps an older version of the API). This may be a case we should handle for backwards compatibility, but it demonstrates this issue at present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant