Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locally running an application (not dat), fails saving files when dat-fox extension is enabled #25

Open
venikx opened this issue Oct 18, 2018 · 1 comment

Comments

@venikx
Copy link

venikx commented Oct 18, 2018

General information

Domain: localhost:3000
Browser: Firefox 62
OS: Void Linux

Scenario

  1. Start a SPA application (for example using React)
  2. Save a file via the front-end application
  3. Open a file saver popup
  4. File is saved
    => OK
  5. Enable dat-fox extensions
  6. Save a file via the front-end application

Expected Result

The browser tries to save a file by showing the pop-up to save a file

Actual Result

Saving the file gives an error URL.createObjectURL is not a function (we are using FileSaver.js and that library is throwing that error) and doesn't open the file saver popup.

Extra information

I noticed that this is only a problem when developing locally on the application, when we create a production build and push to our development instance on AWS we don't have this issue.
Is the extension overriding browser globals? Is there any weird behavior you can think of using localhost?

If you need any more information, I'll try to provide it for you.

@sammacbeth
Copy link
Owner

The extension initially assumes the dat gateway is running on localhost:3000, until the process finishes starting up and communicates its actual port. If you are running other services on port 3000 they may have received some requests from the extension in this time. Does this possibly explain your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants