Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security?] Iframe over Dat replaes top-frame over HTTPS #28

Open
da2x opened this issue Oct 23, 2018 · 1 comment
Open

[security?] Iframe over Dat replaes top-frame over HTTPS #28

da2x opened this issue Oct 23, 2018 · 1 comment

Comments

@da2x
Copy link
Contributor

da2x commented Oct 23, 2018

  1. Load a normal webpage over HTTPS (no CORS or nonsense).

  2. Attempt to load any resource in a sub-frame over Dat on that page

    <iframe src="dat://beakerbrowser.com/img/what-is-beaker.svg"></iframe>

The top frame is unexpectedly redirected to the sub-frame’s address; replacing the entire document with the contents of the iframe. This makes is difficult for use cases like peer-to-peer embedded videos.

Potentially a security vulnerability as any iframe can replace any document they’re loaded in. Unknown impact.

@sammacbeth
Copy link
Owner

This is likely an issue with the webextensions implementation of protocol handlers - these only work for main document requests. You should open an issue on bugzilla as this will probably be possible with any custom protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants