Skip to content
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.

DPL-264 As a Team Leader (Tom) I would like to investigate AutoManual to establish what it does and if it is still needed? [C=M,V=3] #106

Open
4 tasks
TWJW-SANGER opened this issue Jan 31, 2022 · 3 comments

Comments

@TWJW-SANGER
Copy link

TWJW-SANGER commented Jan 31, 2022

Description
A cursory examination of automanual shows it queries the MLWH table iseq_run_lane_metrics for the QC status of runs and posts this information to a SequenceScape endpoint.

I would like to establish:

  • Check the automanual logs, when did automanual last call the SequenceScape API?
  • Where is the QC information provided by the API call displayed in SequenceScape?
  • Ask NPG if they are calling the SS API on automatic QC.
  • Assuming NPG are calling the SS API on QC results, why is this needed for manual QC passes? (Are these NPG calls not being made on manual QC? Is there an ordering problem on the state field, i.e. it's set to passed and then set to something else....?)

Who the primary contacts are for this work
TW

@TWJW-SANGER TWJW-SANGER changed the title As a Team Leader (Tom) I would like to investigate AutoManual to establish what it does and if it is still needed? DPL-264 As a Team Leader (Tom) I would like to investigate AutoManual to establish what it does and if it is still needed? Jan 31, 2022
@KatyTaylor KatyTaylor changed the title DPL-264 As a Team Leader (Tom) I would like to investigate AutoManual to establish what it does and if it is still needed? DPL-264 As a Team Leader (Tom) I would like to investigate AutoManual to establish what it does and if it is still needed? [C=M,V=3] Mar 9, 2022
@KatyTaylor
Copy link

We didn't update automanual for this story - https://github.com/sanger/deployment/issues/73

If it's found that automanual is something that's still used, consider making a new story to implement the above issue (zero downtime deployment) for automanual.

@SujitDey2022
Copy link

@TWJW-SANGER please can you help review the story and confirm if we need this story or if we can archive the same.

@TWJW-SANGER
Copy link
Author

I have updated the acceptance criteria to make them more task based.
I think we still need to do this investigation if we are going to turn off AutoManual. There is a strong possibility it is related to something about the Heron process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants