Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-523 - Remove Heron tube racks code #4570

Open
1 task
KatyTaylor opened this issue Dec 18, 2024 · 0 comments
Open
1 task

Y24-523 - Remove Heron tube racks code #4570

KatyTaylor opened this issue Dec 18, 2024 · 0 comments

Comments

@KatyTaylor
Copy link
Contributor

KatyTaylor commented Dec 18, 2024

Describe the Housekeeping
There is legacy code in Sequencescape to support the creation of tube racks through the API, for the Heron project. This was used for an early iteration of the Heron pipeline, when samples were being processed in the cellular labs and received into SeqOps in tube racks. As far as I know, the code that calls the endpoint has already been deleted (wrangler app, which was polling a table in MLWH?).

  • Remove obsolete Heron tube rack endpoint and associated code.

Additional context
Take a look at:

  • routes - heron namespace - tube_racks
  • controllers/api/v2/heron
  • models/heron/factories/tube_rack
  • 'concerns' used within above factory

This was noticed as part of the work to improve SS & Limber's support for tube racks (stories coming out of sanger/limber#1482).

A lot of the above code is fairly generic, despite being used for Heron only. It could be useful if the same person who does this story also does this refactoring story, in case there is useful code that could be salvaged.

@psd-issuer psd-issuer bot changed the title Remove Heron tube racks code Y24-523 - Remove Heron tube racks code Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant