Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'pkg_resources' requirement #14

Open
nicoddemus opened this issue Oct 29, 2024 · 1 comment
Open

Missing 'pkg_resources' requirement #14

nicoddemus opened this issue Oct 29, 2024 · 1 comment

Comments

@nicoddemus
Copy link

Hi,

Seems like tracerite imports pkg_resources explicitly:

import pkg_resources

For that reason it should declare its dependency on pkg_resources explicitly, I believe:

install_requires = ["html5tagger>=1.2.1"],

This issue was found during the build of sanic for Python 3.13:

conda-forge/sanic-feedstock#65

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1067026&view=logs&jobId=d93976e3-6ed1-588b-ebf8-e8a19c2becc4&j=d93976e3-6ed1-588b-ebf8-e8a19c2becc4&t=90b382e2-e6d3-5178-8133-a486ee34063f

  File "/home/conda/feedstock_root/build_artifacts/sanic_1730241447206/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.13/site-packages/tracerite/__init__.py", line 1, in <module>
    from .html import html_traceback
  File "/home/conda/feedstock_root/build_artifacts/sanic_1730241447206/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.13/site-packages/tracerite/html.py", line 1, in <module>
    import pkg_resources
@jakewins
Copy link

jakewins commented Jan 7, 2025

This PR removes the pkg_resources dependency: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants