Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify APDU's commands? #58

Closed
jarodium opened this issue Jul 3, 2016 · 4 comments
Closed

Simplify APDU's commands? #58

jarodium opened this issue Jul 3, 2016 · 4 comments

Comments

@jarodium
Copy link

jarodium commented Jul 3, 2016

Hello there

Is there any way we can simplify APDU sending and retrieving?
Working with the buffers seems to have quite a steep learning curve for folks who don't understand very much of the subject.

Hopefully a higher level API would be enough and more time saving for those who want this library to work.

The attached file below is an eID Belgian SDK doc, for example on how the APi could be structured

UPD_Developers_Guide.pdf

Below is an APDU.js file taken from the Open Smart Card Development Platform ( http://www.openscdp.org/index.html)

apdu.txt

Best regards
Pedro

@santigimeno
Copy link
Owner

Hi!

Thanks for the comments. Answers inline

Is there any way we can simplify APDU sending and retrieving?
Working with the buffers seems to have quite a steep learning curve for folks who don't understand very much of the subject.

What's the difficulty when using Buffer? Can you more specific?. You can always initialize the Buffer with an Array, which looks quite simple to me.

Hopefully a higher level API would be enough and more time saving for those who want this library to work.

If you could outline an specific API we could discuss it. By skimming through the document I'm not sure what you're exactly proposing.
On the other hand, I would argue that having a Sync API would help: #20. At the moment, I'm not in the need of a Sync API, but would certainly entertain a PR with that functionality.

Best regards.

@jarodium
Copy link
Author

jarodium commented Jul 4, 2016

Hello @santigimeno

Thank you for your reply.

Using buffer, may look simple, but from a first timer's pov, when using this lib and using APDU, I had a hard time figuring where the parameters for APDU should be entered, and I am still battling to figure out how to use all the cases in the spec.

About the API, I figure a Sync API would help, but I really don't mind like it is up untill now.
I can describe a small API specifically for general use.

Do you mind if I put the proposal in another issue?

Best regards
Pedro

@santigimeno
Copy link
Owner

Do you mind if I put the proposal in another issue?

Please do! Looking forward to reading it.

@santigimeno
Copy link
Owner

Closing. Feel free to reopen if you think it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants