Incorrect HTML generated when default codec is html

[jeremydawson]

Thank you for the nice plugin with good documentation.

In the Config.groovy for my app, I have the default codec set to html:

grails.views.default.codec = "html"

This causes all content inside ${ } to be HTML-escaped. It looks like there are a few spots in the plugin's templates that assume that this parameter is set to "none", as the plugin generates the following HTML:

<form id="fileupload" action="/myController/upload" method="POST" enctype=&quot;multipart/form-data&quot;>

and

<!-- The table listing the files available for upload/download -->
<table class="table table-striped">
  <tbody class="files" data-toggle="modal-gallery" data-target="#modal-gallery">

  </tbody>
</table>

If I switch the codec to "none" then the HTML gets generated properly, but there are other places in my app that assume this is set to "html".

My proposed solution is to modify the plugin templates to use the <%= %> syntax instead of ${ } when HTML is being produced. So in _list.gsp the following line:

  <tbody ${filesContainer ? (filesContainer.startsWith('.') ? 'class="' + filesContainer.substring(1) + '"' : 'id="' + filesContainer.substring(1) + '"') : 'class="files"'} data-toggle="modal-gallery" data-target="#modal-gallery">

would be replaced with:

<tbody <%=filesContainer ? (filesContainer.startsWith('.') ? 'class="' + filesContainer.substring(1) + '"' : 'id="' + filesContainer.substring(1) + '"') : 'class="files"' %> data-toggle="modal-gallery" data-target="#modal-gallery">

In _form.gsp, replace:

<form id="${id}" action="${url}" method="${type}" ${multipart ? 'enctype="multipart/form-data"' : ''}>

with:

<form id="${id}" action="${url}" method="${type}" <%=multipart ? 'enctype="multipart/form-data"' : ''%> >

and replace:

  ${list}

with:

  <%=list%>

[sarbogast]

I didn't know about this difference between ${} and <%=%>
I'll make the change as soon as possible.

[jeremydawson]

I didn't know about that difference either...
This page has a good explanation:
http://alwaysthecritic.typepad.com/atc/2010/06/grails-gsp-html-escaping-confusion.html