You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ObsPrior class in the source code of priors.py appears to want the required arguments ordered as: epochs, ra_err, dec_err, mtot, but the tutorial provides these arguments in the order: ra_err, dec_err, epochs, mtot (in the tutorial, the last of these is the system_mass variable).
The astropy.table.column.Column variable for the error in relative declination, dec_err, should be assigned the value: mySystem.data_table["quant2_err"], but the tutorial assigns: mySystem.data_table["quant1_err"] (i.e., the same astropy.table.column.Column for relative right ascension as assigned to ra_err in the tutorial).
Describe the bug
ObsPrior
class in the source code ofpriors.py
appears to want the required arguments ordered as:epochs, ra_err, dec_err, mtot
, but the tutorial provides these arguments in the order:ra_err, dec_err, epochs, mtot
(in the tutorial, the last of these is thesystem_mass
variable).astropy.table.column.Column
variable for the error in relative declination,dec_err
, should be assigned the value:mySystem.data_table["quant2_err"]
, but the tutorial assigns:mySystem.data_table["quant1_err"]
(i.e., the sameastropy.table.column.Column
for relative right ascension as assigned tora_err
in the tutorial).To Reproduce
Go to: Using the O’Neil (2019) Observation-based Priors, Priors to compare argument ordering and see the
dec_err
assignment in the tutorial.Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: