From 47d70cc1210e1293467ba22fec37c3184a0c882b Mon Sep 17 00:00:00 2001
From: Jaime R Calzada <jreniel@gmail.com>
Date: Sat, 27 Feb 2021 20:24:40 -0500
Subject: [PATCH] bugfix: bad logger init

---
 pyschism/cmd/bctides.py |  3 ++-
 pyschism/io/bctides.py  | 44 ++++++++++++++++++++++-------------------
 2 files changed, 26 insertions(+), 21 deletions(-)

diff --git a/pyschism/cmd/bctides.py b/pyschism/cmd/bctides.py
index 8977ce19..edce98e8 100644
--- a/pyschism/cmd/bctides.py
+++ b/pyschism/cmd/bctides.py
@@ -54,4 +54,5 @@ def add_bctides(subparsers):
         help="Allow overwrite of output file.")
     bctides.add_argument(
         "--log-level",
-        choices=[name.lower() for name in logging._nameToLevel])
+        choices=[name.lower() for name in logging._nameToLevel],
+        default='warning')
diff --git a/pyschism/io/bctides.py b/pyschism/io/bctides.py
index 941a71fd..59e8cd2f 100644
--- a/pyschism/io/bctides.py
+++ b/pyschism/io/bctides.py
@@ -5,11 +5,13 @@
 import pytz
 
 from pyschism.forcing.tides.tides import Tides
-from pyschism.mesh import Hgrid, hgrid
+from pyschism.mesh import Hgrid
+
 
 def datetime_is_naive(d) -> bool:
     return d.tzinfo is None or d.tzinfo.utcoffset(d) is None
 
+
 def datetime_is_aware(d) -> bool:
     return d.tzinfo is not None and d.tzinfo.utcoffset(d) is not None
 
@@ -25,6 +27,7 @@ def __set__(self, obj, val: Hgrid):
     def __get__(self, obj, val):
         return obj.__dict__['hgrid']
 
+
 class StartDateDescriptor:
 
     def __set__(self, obj, val: datetime):
@@ -38,7 +41,8 @@ def __set__(self, obj, val: datetime):
 
     def __get__(self, obj, val):
         return obj.__dict__['start_date']
-        
+
+
 class RndayDescriptor:
 
     def __set__(self, obj, val: Union[int, float, timedelta]):
@@ -48,11 +52,12 @@ def __set__(self, obj, val: Union[int, float, timedelta]):
                 f'{timedelta}, not type {type(val)}.')
         if not isinstance(val, timedelta):
             val = timedelta(days=val)
-        obj.__dict__['rnday'] = val 
+        obj.__dict__['rnday'] = val
 
     def __get__(self, obj, val) -> timedelta:
         return obj.__dict__['rnday']
 
+
 class Bctides:
 
     _hgrid = HgridDescriptor()
@@ -119,7 +124,7 @@ def write(self, path, overwrite: bool = False):
         path = pathlib.Path(path)
         if path.exists() and not overwrite:
             raise IOError('path exists and overwrite is False')
-        open(path, 'w').write(str(self))
+        open(path.resolve(), 'w').write(str(self))
 
     def get_forcing(self, boundary):
 
@@ -161,12 +166,14 @@ def forcing_digit(pos):
 
             else:
                 raise ValueError(f'Unhandled argument pos={pos}.')
-        
+
         def get_forcing(pos, digit):
-            f =[]
-            if pos == 1: # elevation
-                if digit == 3: # tides
-                    if self.elevation is True: # default tidal elevation
+
+            f = []
+
+            if pos == 1:  # elevation
+                if digit == 3:  # tides
+                    if self.elevation is True:  # default tidal elevation
                         for constituent in \
                                 self.tides.get_active_forcing_constituents():
                             f.append(f'{constituent}')
@@ -183,8 +190,8 @@ def get_forcing(pos, digit):
                 else:
                     raise ValueError(
                         f'Unhandled elevation forcing digit={digit}')
-            elif pos == 2: # velocity
-                if self.velocity is True: # default tidal velocity
+            elif pos == 2:  # velocity
+                if self.velocity is True:  # default tidal velocity
                     for constituent in \
                             self.tides.get_active_forcing_constituents():
                         f.append(f'{constituent}')
@@ -193,8 +200,8 @@ def get_forcing(pos, digit):
                         uamp, uphase, vamp, vphase = self.tides.get_velocity(
                             constituent, vertices)
                         for i in range(len(vertices)):
-                            f.append(f'{uamp[i]:.8e} {uphase[i]:.8e} ' \
-                                        f'{vamp[i]:.8e} {vphase[i]:.8e}')
+                            f.append(f'{uamp[i]:.8e} {uphase[i]:.8e} '
+                                     f'{vamp[i]:.8e} {vphase[i]:.8e}')
                     return '\n'.join(f)
                 else:
                     raise TypeError(
@@ -202,20 +209,17 @@ def get_forcing(pos, digit):
             else:
                 raise TypeError('Unhandled forcing at pos={pos}.')
 
-
         f = [' '.join(list(map(forcing_digit, range(5 + len(self._tracers)))))]
+
         for i in range(1, 5 + len(self._tracers)):
             if int(forcing_digit(i)) > 0:
                 f.append(get_forcing(i, int(forcing_digit(i))))
         return '\n'.join(f)
 
-
-
-
     @property
     def hgrid(self):
         return self._hgrid
-    
+
     @property
     def tides(self):
         return self._tides
@@ -235,11 +239,11 @@ def elevation(self):
     @property
     def velocity(self):
         return self._velocity
-    
+
     @property
     def temperature(self):
         return self._temperature
 
     @property
     def salinity(self):
-        return self._salinity
\ No newline at end of file
+        return self._salinity