Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to load in gnome 45.1 (fedora 39) #75

Open
pieska opened this issue Nov 7, 2023 · 10 comments
Open

failed to load in gnome 45.1 (fedora 39) #75

pieska opened this issue Nov 7, 2023 · 10 comments

Comments

@pieska
Copy link

pieska commented Nov 7, 2023

it's broken again. worked in gnome 44 (with fixes),doesn nit load in gnome 45.1:

Nov 07 22:04:37 gnome-shell[1667]: JS ERROR: Extension [email protected]: SyntaxError: import declarations may only appear at top level of a module @ resource:///org/gnome/shell/ui/main.j>

Does anyone knows how to fix it?

@xkahn
Copy link

xkahn commented Nov 22, 2023

I'm working on the solution for this here: https://github.com/xkahn/connectionmanager2/tree/gnome-45
But it isn't working yet and it's slow going. If anyone else is interested in helping out, I'm accepting help!

@pieska
Copy link
Author

pieska commented Nov 24, 2023

I would love to help out, but I know nothing about java script, I'm more a hardware guy. nut you should use my fork https://github.com/pieska/connectionmanager2 to start with, it has all the fixes for gnome 44.

@xkahn
Copy link

xkahn commented Nov 26, 2023

@pieska Ah ha! This is great. I was missing 6 of those 7 patches. It should speed up the port significantly.

@sbadger
Copy link

sbadger commented Feb 23, 2024

@xkahn Tried your gnome-45 branch out but I am seeing the following error:
Extension [email protected]: SyntaxError: redeclaration of let Me @ file:///home/######/.local/share/gnome-shell/extensions/[email protected]/search.js:35:6

@xkahn
Copy link

xkahn commented Feb 26, 2024

@sbadger Ah yes.... I got busy and stopped paying attention to this issue. Thanks for the ping. I'll see if I can finish this up.

@xkahn
Copy link

xkahn commented Feb 26, 2024

@sbadger Huh. I was closer than I thought. I just committed a few changes to the repo. It should work now.

@pieska
Copy link
Author

pieska commented Feb 28, 2024

@xkahn Does not work for me in a new fully patched F39 VM but I cannot open an issue at https://github.com/xkahn/connectionmanager2, so here are the errors at startup:

Feb 28 11:56:49 localhost-live gnome-shell[1208]: JS WARNING: [file:///usr/share/gnome-shell/extensions/[email protected]/search.js 128]: unreachable code after return statement
Feb 28 11:56:49 localhost-live gnome-shell[1208]: Extension [email protected]: TypeError: global.logError is not a function
                                                                   
                                                                   Stack trace:
                                                                     _readConf@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:125:20
                                                                     ConnectionManager@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:88:14
                                                                     enable@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:333:19
                                                                     _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:253:38
                                                                     loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:461:32
                                                                     async*_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:759:24
                                                                     async*_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:765:48
                                                                     _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:800:20
                                                                     async*init@resource:///org/gnome/shell/ui/extensionSystem.js:72:14
                                                                     _initializeUI@resource:///org/gnome/shell/ui/main.js:303:22
                                                                     start@resource:///org/gnome/shell/ui/main.js:176:11
                                                                     @resource:///org/gnome/shell/ui/init.js:12:47
                                                                     @resource:///org/gnome/shell/ui/init.js:21:20

@xkahn
Copy link

xkahn commented Feb 28, 2024

@pieska ...huh. That was a line I hadn't touched. I've changed the error logging to be console.error instead.

@sbadger
Copy link

sbadger commented Feb 28, 2024

@sbadger Huh. I was closer than I thought. I just committed a few changes to the repo. It should work now.

It is working fully for me on Fedora 39.
Thanks for you work!

@pieska
Copy link
Author

pieska commented Feb 29, 2024

@sbadger Huh. I was closer than I thought. I just committed a few changes to the repo. It should work now.

It is working fully for me on Fedora 39. Thanks for you work!

confirmed! thank you @xkahn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants