Support for Number.prototype.toLocaleString with arguments

[terrymun]

Even though Internationalization support is documented in the readme, I realized that it is not possible to provide arguments to the Number.prototype.toLocaleString method.

For example, the following examples will not work in the latest v2 release:

// Expects: 1,337.6
new Number (1337.56).toLocaleString('en-US', {
  minimumFractionDigits: 0,
  maximumFractionDigits: 1,
  useGrouping: true
});

[sebastienros]

@terrymun do you want to try and implement this?

[sebastienros]

Here probably: https://github.com/sebastienros/jint/blob/dev/Jint/Native/Number/NumberPrototype.cs#L53

The specification is in this document:
http://ecma-international.org/ecma-402/6.0/index.html#sup-number.prototype.tolocalestring

[terrymun]

@sebastienros I would very much love to help, but I am, unfortunately, quite unfamiliar with C# to be honest. I have created this issue because of the backend part of a project that requires JS evaluation on the server-side.

[LuisMerinoP]

Hi, I gave this a shot. I have branch for this but cannot push. Not very proud of the solution and its done with a shortcut.
Problem is that to do it the right way NumberFormat's methods need to be implemented. This is ResolveLocale and all the ones called from there which are a lot:

• LookupMatcher
• BestFitMatcher
• UnicodeExtensionComponents
• ...and many more

So tons of work to do it the right way. If I get permissions I would like to share the PR for thought sharing and possible contribution if you will. Thanks a lot. Awesome project btw!

[lahma]

You can push to your own repository and create a pull request against this repository to demonstrate your changes. You don't need write access to PR's target repository.

[LuisMerinoP]

thanks @lahma. Creating #1619.

[lahma]

I'm closing this as initial version has been merged and published to NuGet, we can refine with PRs.