Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <title>Ledger signing timelock script input does not work #199

Open
1 task done
elRaulito opened this issue Jan 3, 2025 · 3 comments
Open
1 task done

[bug] <title>Ledger signing timelock script input does not work #199

elRaulito opened this issue Jan 3, 2025 · 3 comments
Assignees

Comments

@elRaulito
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

SATS-CONNECT Version

2.4.0

Current Behavior

Currently using timelock scripts in Bitcoin, I need to sign inputs coming from Bitcoin timelock script and from the bitcoin payment address using ledger wallet and xverse

I am signing all inputs using same pubkey however apparently the usual xverse way to sign inputs is not working

Should I split the process and sign first the time lock script inputs and then the payment inputs?

Please let me know

Expected Behavior

Since I am using the same pubkey I expect that I would be able to sign everything in once

Steps To Reproduce

Lock some BTC in a bitcoin timelock script and then try to unlock using ledger

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response

@secretkeylabs secretkeylabs deleted a comment Jan 4, 2025
@secretkeylabs secretkeylabs deleted a comment Jan 4, 2025
@victorkirov victorkirov self-assigned this Jan 6, 2025
@victorkirov
Copy link
Member

Hey @elRaulito

For Ledger, things are a bit more complicated. You cannot sign for alternate addresses generated from the pubKey; only for the ones specified in the wallet (Native segwit and taproot). When sending a sign request to Ledger, you need to specify how the address was derived in a wallet descriptor that is passed to the Ledger device so the user can confirm they are signing the correct thing.

We currently don't expose passing in a custom wallet descriptor for custom ledger addresses.

@elRaulito
Copy link
Author

Thanks @victorkirov

Is there a way to create multisig using ledger then?
Anyway thanks a lot

Also importing the ledger seed in a hot wallet (making it useless) will get same addresses?

@victorkirov
Copy link
Member

Multisig with Ledger is pretty limited, so we haven't really exposed the functionality as it has some hard requirements that are difficult to get around and would cause dev issues and require a lot of support.

Yeah, importing the ledger seed would result in the same addresses, but it would make the cold wallet kind of pointless, as you mentioned 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@victorkirov @elRaulito and others