Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can TcpReassembly call m_OnMessageReadyCallback and m_OnConnStart only after recieved complete TCP handshake? #1671

Open
MCredbear opened this issue Dec 26, 2024 · 1 comment
Labels

Comments

@MCredbear
Copy link
Contributor

Question

If I don't get wrong, current TcpReassembly calls these 2 functions whether the TCP handshake is complete, right?

Operating systems

Linux

@seladb
Copy link
Owner

seladb commented Jan 1, 2025

m_OnConnStart is called whenever a new TCP flow is discovered, it doesn't wait for a complete TCP handshake.
m_OnMessageReadyCallback is called whenever there is data on a TCP flow which of course happens after the TCP handshake and when data is sent between the 2 sides of the connection.

These 2 callbacks are probably not the right ones to call when TCP handshake is completed. If we need this event we probably need a new callback m_OnTcpHandshakeCompleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants