Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default styles fail accessibility contrast lighthouse rules #30

Open
NateRadebaugh opened this issue Apr 12, 2020 · 3 comments
Open

Default styles fail accessibility contrast lighthouse rules #30

NateRadebaugh opened this issue Apr 12, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@NateRadebaugh
Copy link
Contributor

Out of the box (light theme), running Lighthouse audits, I'm not getting 100% in accessibility...

"Background and foreground colors do not have a sufficient contrast ratio."

image

@siddharthkp
Copy link
Owner

That's a great bug report! I'll look into it 👍

@siddharthkp siddharthkp added the bug Something isn't working label Apr 12, 2020
@siddharthkp siddharthkp self-assigned this Apr 12, 2020
@siddharthkp siddharthkp added this to the 1.0.0 milestone Apr 16, 2020
@ankibalyan
Copy link
Contributor

Can we integrate some tool to check color contrasts during build or after build?

Something on these lines.

https://github.com/bbc/color-contrast-checker
https://dev.to/alvaromontoro/building-your-own-color-contrast-checker-4j7o

@siddharthkp
Copy link
Owner

Can we integrate some tool to check color contrasts during build or after build?

When it comes to default themes, I wouldn't try to solve it with CI/build tooling. Assigned it to myself to work on the default colors

@siddharthkp siddharthkp removed their assignment Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants