Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full width prop to the button #31

Open
ankibalyan opened this issue Apr 12, 2020 · 4 comments
Open

Full width prop to the button #31

ankibalyan opened this issue Apr 12, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ankibalyan
Copy link
Contributor

It would be good if Button component supports fullwidth prop, it often required in mobile views.

Button will occupied full width of the container
<Button fullwidth></Button>

Button will be full width in mobile view, but It'll behave normal in other modes
<Button fullwidth={[true, false]}></Button>

@ankibalyan
Copy link
Contributor Author

I'd be happy to send a PR if this is useful to have on Button components.

@siddharthkp siddharthkp added the enhancement New feature or request label Apr 13, 2020
@siddharthkp
Copy link
Owner

I can imagine this prop being useful for multiple building blocks

would you like to pair on this?

@ankibalyan
Copy link
Contributor Author

yes surely.

@ankibalyan
Copy link
Contributor Author

I think it can added on element component itself, and checked on the fullWidth keyword to set the width. I'll send a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants