Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a create theme utility function #59

Open
ankibalyan opened this issue May 4, 2020 · 2 comments
Open

Adding a create theme utility function #59

ankibalyan opened this issue May 4, 2020 · 2 comments

Comments

@ankibalyan
Copy link
Contributor

Currently, When it is required to create a new theme we need to explicitly create a new theme and copy paste add all the necessary things from the base theme.
Or we need to clone a base/ light/ dark theme and then merge to them.

what about create a utility function similar to material-ui to extends one of its core theme safely along with all the components CSS so things doesn't break.

@ankibalyan
Copy link
Contributor Author

Or may be adding an example of extending to a full new theme to docs may also help.

@siddharthkp
Copy link
Owner

siddharthkp commented May 5, 2020

I'm slightly skeptical about encouraging folks to extend the in built theme

  1. on one hand, if you only want to change one thing, it would be annoying to copy paste the whole thing
  2. on the other, if you want to refer to tokens, which means you'll have to dig into the theme to find the correct keys, making the theme yours by copy pasting makes that path easier

That said, definitely needs a page in the docs when we have a solid opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants