-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to rems during render #90
Comments
we can do it by converting our base font to 10px and with that calculation will also become easier for rem units.
so this will be conversion afterwards.
reference: https://developer.mozilla.org/en-US/docs/Web/CSS/font-size |
Open for discussion, let me know if you've something else in mind. |
Another reference from Material-UI, they suggest this change from theme creation utility function. |
@ankibalyan you can look at the history of this MUI markdown, I think that we link an older article about the topic, maybe from 2011. |
@oliviertassinari sorry, I did't see any old article. can you please link it. |
Authoring styles on a scale removes the need to think in units, but we should recommend folks to define their themes with rems instead of px (including the default themes) so that we make sure the result is accessible :)
The text was updated successfully, but these errors were encountered: