Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent format for 1.41 release assets #2299

Open
gvinaccia opened this issue Dec 11, 2024 · 7 comments
Open

Inconsistent format for 1.41 release assets #2299

gvinaccia opened this issue Dec 11, 2024 · 7 comments
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. docs Documentation-related. packaging Dependencies, version constraints, packaging.. platform:linux platform:mac

Comments

@gvinaccia
Copy link

the 1.41 release assets are in zip format instead of the usual .tar.gz, and the linux zip archive includes a tarball

@Flimm
Copy link
Contributor

Flimm commented Dec 12, 2024

The instructions for installing the Linux version on this page are incorrect: https://github.com/simonmichael/hledger/releases/tag/1.41 The instructions expect a .tar.gz file, whereas the download is a .zip file.

@simonmichael
Copy link
Owner

simonmichael commented Dec 12, 2024

Thanks for the reports!

the 1.41 release assets are in zip format instead of the usual .tar.gz, and the linux zip archive includes a tarball

IIRC,

  • everything is in a zip because of a github limitation; it essentially forces that
  • linux and mac have a tarball inside the zip to preserve the executable file permissions (zip doesn't do that). It removes one extra step / source of confusion for installers.

The instructions for installing the Linux version on this page are incorrect:

  • they and the mac instructions should be correct now.

@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. platform:linux docs Documentation-related. platform:mac packaging Dependencies, version constraints, packaging.. labels Dec 12, 2024
@gvinaccia
Copy link
Author

Thank you @simonmichael for the quick reply and the wonderful piece of software

@simonmichael
Copy link
Owner

Thanks! I'll close this then, noting that an easier binary command would be nice.

@simonmichael
Copy link
Owner

simonmichael commented Dec 13, 2024

I researched this again. Here are some links on the github zip limitation:

I have forgotten if the limitation is with the upload-artifact tool, or github releases in general. I kind of thought it was the latter.

So when I see tar.gz files on some projects' releases, eg https://github.com/jgm/pandoc/releases/tag/3.6, I'm assuming those were uploaded by hand. Or, they are actually zip files, containing a tar.gz file, I can't be bothered to check just now.

I also found some tools that aim to make downloading github binaries easier (eget, ubi, gah, gogo, and github's own gh tool).

And, I found a project that uses gh to create and upload artifacts to releases (instead of upload-artifact). Still not sure if that gets around the zip limitation but it was a useful discovery, I can use that in lots of ways.

@hseg
Copy link
Contributor

hseg commented Dec 30, 2024

@simonmichael Looking at https://cli.github.com/manual/gh_release_create (look for the example uploading ./dist/*.tgz), it appears that may be a solution.

Returning to the old behaviour would be nice for me, since Arch Linux's makepkg tries to autoextract1 the artifact, but ends up only unwrapping the .zip container, leaving the .tar intact. Which makes sense, because both are archive formats, so you wouldn't want the automagic to extract both.

@simonmichael simonmichael reopened this Jan 4, 2025
@simonmichael
Copy link
Owner

Reopening this for future improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. docs Documentation-related. packaging Dependencies, version constraints, packaging.. platform:linux platform:mac
Projects
None yet
Development

No branches or pull requests

4 participants