Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native window decorations #13721

Open
pztrn opened this issue Jan 3, 2025 · 7 comments
Open

Native window decorations #13721

pztrn opened this issue Jan 3, 2025 · 7 comments

Comments

@pztrn
Copy link

pztrn commented Jan 3, 2025

In what scenarios do you need this feature?

On Linux CSDs doesn't draw shadows which results in ugly window decorations as well as inability to differentiate SiYuan window from others (especially with light theme).

See https://liuyun.io/article/1732705567248 for example.

Describe the optimal solution

Ability to enable system decorations in settings.

Describe the candidate solution

No response

Other information

SiYuan v3.1.17 on last-year (:trollface:) Arch KDE (Wayland).

@88250
Copy link
Member

88250 commented Jan 6, 2025

Please take a screenshot in the default theme

@pztrn
Copy link
Author

pztrn commented Jan 6, 2025

изображение

Default dark theme on Firefox with my post on forum opened.

Anyway all windows have shadows (even windows with client-side decorations), only electron applications that implements own window controls looks ugly.

@pztrn
Copy link
Author

pztrn commented Jan 6, 2025

изображение

And light theme. Lack of shadows just hurts.

@88250
Copy link
Member

88250 commented Jan 6, 2025

I roughly understand that there are different desktop systems on the Linux platform. If the native window title bar is used, it may be uglier and the operations on the title bar cannot be unified, so the title bar is not considered for adjustment.

The window border and shadow should exist to be normal, for example, on Windows:

image

We will try to troubleshoot this problem later, thank you for your feedback.

@pztrn
Copy link
Author

pztrn commented Jan 6, 2025

It may be disabled by default option in settings, as I said in first post.

In my experience, current behavior is fine for Windows and macOS which draws shadows on it's own, but on Linux shadown are drawn by window managers only if window decorations are present. Currently e.g. KWin (KDE,s window manager) considering that window has no decorations and draws no shadow. The very same applies to at least XFWM (XFCE window manager) and Mutter (GNOME window manager). And actually there is nothing you can do except disabling frameless mode. See this electron issue which says that even adding shadows in CSS breaks UX and windows became unresizable. As always, issue was closed with no real solution, but even VSCode with custom titlebar misses shadows in Linux.

@88250
Copy link
Member

88250 commented Jan 6, 2025

Could you try to modify this and test it for us?

image

@Menghuan1918
Copy link
Contributor

图片
Or should it be the same as vscode, providing an option to choose whether to use the native titlebar or the software titlebar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants