[DOC] Correct argument for optimizer ranger in Temporal Fusion Transformer tutorial
#1724
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fnhirwa
requested review from
benHeid,
fkiraly,
jdb78 and
yarnabrina
as code owners
fnhirwa
requested review from
geetu040,
pranavvp16 and
XinyuWuu
as code owners
|
The issue was the training of the Also increased the timeout in the tests to 1200s due to the training time |
docs/source/tutorials/stallion.ipynb
Outdated
There was a problem hiding this comment.
I'm unable to see this diff in Github (it saus unable to render rich diff), and ReviewNB also seems to lack the notebook.
There was a problem hiding this comment.
I'm not quite sure about that, I logged in with my github and was able to see diff on ReviewNB
There was a problem hiding this comment.
Not sure why it's not working for me, but not a big deal. I checked it from branch it directly.
I am not what change of yours is making the predictions worse. In main branch, the predicted orange line and shaded area seemed to contain the blue actuals pretty well, but in the modified one the gaps seem to have increased notably. Do you agree with observation? Any guess what's causing it (seed remained same at 42 in both cases)?
There was a problem hiding this comment.
I'm not sure about the cause as I can see even the learning_rate got changed from 0.041 to 0.009. I think I'll need to check the logs and see where it is going wrong
There was a problem hiding this comment.
I rerun the notebook now the losses seems to have been reduced
Yeah, this sounds great we can do it. |
|
I think the best approach is to have a broader task for reworking the examples as the ones available now seem to be written a long time ago. With this we can ensure that we have low runtime working examples. |
fixes error in the tutorial which was causing examples to fail.
fixes #1722