Fix/codelens support multiple messages #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's a couple of things going wrong here :/ 
|
|
It looks like the chat is being called twice so there's two streams |
this one is tricky, needs a bit of reconsideration on how to get it or maybe this one is getting parsed in LSP binary |
MarcMcIntosh
reviewed
Jan 7, 2025
| if (('type' in content) && content.type === 'text') { | ||
| return replaceVariablesInText(content.text, relative_path, cursor, text); | ||
| } | ||
| }).join("\n"); |
There was a problem hiding this comment.
Will join concat all the objects to a string ?
There was a problem hiding this comment.
only if there's images, I don't think code lens will be adding images :)
MarcMcIntosh
approved these changes
Jan 7, 2025
| if (('type' in content) && content.type === 'text') { | ||
| return replaceVariablesInText(content.text, relative_path, cursor, text); | ||
| } | ||
| }).join("\n"); |
There was a problem hiding this comment.
only if there's images, I don't think code lens will be adding images :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #275 pull request of
refact-chat-js